Skip to content

Conversation

@plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 1, 2023

continuing the efforts started in #898 #922 #923 #930 #937 #938 #941 #942 #950

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner September 1, 2023 14:44
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #951 (dc08241) into main (ccc46bf) will increase coverage by 0.01%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   70.94%   70.95%   +0.01%     
==========================================
  Files         312      312              
  Lines       12916    12923       +7     
==========================================
+ Hits         9163     9170       +7     
  Misses       3287     3287              
  Partials      466      466              
Files Changed Coverage Δ
secret/native/count.go 37.50% <40.00%> (ø)
secret/native/list.go 30.15% <40.00%> (ø)
secret/native/get.go 47.50% <50.00%> (ø)
secret/native/delete.go 44.73% <60.00%> (ø)
secret/native/update.go 62.50% <60.00%> (ø)
database/resource.go 72.03% <100.00%> (+0.23%) ⬆️
database/secret/count.go 100.00% <100.00%> (ø)
database/secret/count_org.go 100.00% <100.00%> (ø)
database/secret/count_repo.go 100.00% <100.00%> (ø)
database/secret/count_team.go 100.00% <100.00%> (ø)
... and 22 more

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 0464cb5 into main Sep 7, 2023
@plyr4 plyr4 deleted the enhance/ctx-secret branch September 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants